From 30d96139c21700ddf84e8faf7772a18691031f22 Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Sun, 29 Jul 2018 16:05:49 -0700 Subject: [PATCH] Remove commit param from PDB.sql_* methods nobody was using. And is better left to the caller anyway. --- etiquette/photodb.py | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/etiquette/photodb.py b/etiquette/photodb.py index daebe8e..2b094a7 100644 --- a/etiquette/photodb.py +++ b/etiquette/photodb.py @@ -732,14 +732,11 @@ class PDBSQLMixin: self.on_commit_queue.append(savepoint_id) return savepoint_id - def sql_delete(self, table, pairs, *, commit=False): + def sql_delete(self, table, pairs): (qmarks, bindings) = sqlhelpers.delete_filler(pairs) query = 'DELETE FROM %s %s' % (table, qmarks) self.sql_execute(query, bindings) - if commit: - self.commit() - def sql_execute(self, query, bindings=[]): if bindings is None: bindings = [] @@ -747,16 +744,13 @@ class PDBSQLMixin: cur.execute(query, bindings) return cur - def sql_insert(self, table, data, *, commit=False): + def sql_insert(self, table, data): column_names = constants.SQL_COLUMNS[table] (qmarks, bindings) = sqlhelpers.insert_filler(column_names, data) query = 'INSERT INTO %s VALUES(%s)' % (table, qmarks) self.sql_execute(query, bindings) - if commit: - self.commit() - def sql_select(self, query, bindings=None): cur = self.sql_execute(query, bindings) while True: @@ -769,14 +763,11 @@ class PDBSQLMixin: cur = self.sql_execute(query, bindings) return cur.fetchone() - def sql_update(self, table, pairs, where_key, *, commit=False): + def sql_update(self, table, pairs, where_key): (qmarks, bindings) = sqlhelpers.update_filler(pairs, where_key=where_key) query = 'UPDATE %s %s' % (table, qmarks) self.sql_execute(query, bindings) - if commit: - self.commit() - class PDBTagMixin: def __init__(self):