From 4e3e2fea12bdaf15e885b4b3ae22a98e63c075a3 Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Sat, 3 Oct 2020 18:32:21 -0700 Subject: [PATCH] Avoid creating emptystring promptclass. --- frontends/etiquette_flask/static/js/common.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/frontends/etiquette_flask/static/js/common.js b/frontends/etiquette_flask/static/js/common.js index 31e2f2f..60aab52 100644 --- a/frontends/etiquette_flask/static/js/common.js +++ b/frontends/etiquette_flask/static/js/common.js @@ -278,7 +278,13 @@ function init_button_with_confirm(button) button.classList.remove("button_with_confirm"); const holder = document.createElement("span"); - holder.className = "confirm_holder " + (button.dataset.holderClass || ""); + holder.className = ("confirm_holder " + (button.dataset.holderClass || "")).trim(); + delete button.dataset.holderClass; + if (button.dataset.holderId) + { + holder.id = button.dataset.holderId; + delete button.dataset.holderId; + } button.parentElement.insertBefore(holder, button); const holder_stage1 = document.createElement("span"); @@ -304,7 +310,10 @@ function init_button_with_confirm(button) prompt.innerText = (button.dataset.prompt || "Are you sure?") + " "; input_source = undefined; } - prompt.className = button.dataset.promptClass || ""; + if (button.dataset.promptClass) + { + prompt.className = button.dataset.promptClass; + } holder_stage2.appendChild(prompt) delete button.dataset.prompt; delete button.dataset.promptClass;