From 55e12817747abdf504368bc295a59738fe3e3153 Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Mon, 15 Jan 2018 18:56:41 -0800 Subject: [PATCH] Improve technique for finding cookie set by function. Instead of iterating through all the outgoing headers. --- frontends/etiquette_flask/etiquette_flask/sessions.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/frontends/etiquette_flask/etiquette_flask/sessions.py b/frontends/etiquette_flask/etiquette_flask/sessions.py index 069ba01..26dafb7 100644 --- a/frontends/etiquette_flask/etiquette_flask/sessions.py +++ b/frontends/etiquette_flask/etiquette_flask/sessions.py @@ -70,10 +70,8 @@ class SessionManager: # Send the token back to the client # but only if the endpoint didn't manually set the cookie. - for (headerkey, value) in response.headers: - if headerkey == 'Set-Cookie' and value.startswith('etiquette_session='): - break - else: + function_cookies = response.headers.get_all('Set-Cookie') + if not any('etiquette_session=' in cookie for cookie in function_cookies): response.set_cookie( 'etiquette_session', value=session.token,