From 5dcccae64681109fb0f0661c3ec3a4040643c651 Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Sat, 12 Sep 2020 13:14:40 -0700 Subject: [PATCH] Fix add_children all(bail) causing short-circuit. --- etiquette/objects.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/etiquette/objects.py b/etiquette/objects.py index b863b8f..f6f7f94 100644 --- a/etiquette/objects.py +++ b/etiquette/objects.py @@ -119,7 +119,10 @@ class GroupableMixin: return self._add_child(member) def add_children(self, members): - if all(self._add_child(member) is BAIL for member in members): + bail = True + for member in members: + bail = bail and (self._add_child(member) is BAIL) + if bail: return BAIL def assert_same_type(self, other):