From a7d93b7223e8821233d8d8c3a6b3ed7644c09e8b Mon Sep 17 00:00:00 2001
From: Ethan Dalool <git@voussoir.net>
Date: Fri, 23 Aug 2019 13:24:47 -0700
Subject: [PATCH] Simplify the code for add_new_orderby a little bit.

---
 frontends/etiquette_flask/templates/search.html | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/frontends/etiquette_flask/templates/search.html b/frontends/etiquette_flask/templates/search.html
index 56d52f7..ad73102 100644
--- a/frontends/etiquette_flask/templates/search.html
+++ b/frontends/etiquette_flask/templates/search.html
@@ -436,17 +436,15 @@ function add_new_orderby()
 {
     /* Called by the green + button */
     var ul = document.getElementById("search_builder_orderby_ul");
-    if (ul.children.length >= 9)
+    var lis = ul.children;
+    if (lis.length >= 9)
     {
         /* 9 because there are only 9 sortable properties */
         return;
     }
-    var li = ul.children;
-    li = li[li.length - 2];
-    var clone_children = true;
-    var new_li = li.cloneNode(clone_children)
-    var button = document.getElementById("search_builder_orderby_newrow");
-    ul.insertBefore(new_li, button);
+    prev_li = lis[lis.length - 2];
+    var new_li = prev_li.cloneNode(true);
+    ul.insertBefore(new_li, prev_li.nextSibling);
 }
 function orderby_remove_hook(button)
 {