From bdff14ecf2ba2dacbe8e8b6432a304ac7fae01cc Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Fri, 26 Apr 2019 23:14:14 -0700 Subject: [PATCH] Identify a logic error without actually fixing it. :sunglasses: --- etiquette/photodb.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/etiquette/photodb.py b/etiquette/photodb.py index b955f3c..a08debb 100644 --- a/etiquette/photodb.py +++ b/etiquette/photodb.py @@ -835,6 +835,11 @@ class PDBTagMixin: tagname = tagname.tagname try: + # TODO: this logic is flawed because tags that were created in + # the past may have had different normalization. + # At the same time, I don't want to just pass the input directly + # into the query, we should still do SOME assumed normalization + # like whitespace strip. tagname = objects.Tag.normalize_name( tagname, valid_chars=self.config['tag']['valid_chars'],