From e62aa2f74048c70e0bc1bcf153c3cb0a1847ff3f Mon Sep 17 00:00:00 2001 From: Ethan Dalool Date: Wed, 22 Mar 2017 18:06:02 -0700 Subject: [PATCH] Make condition look better --- etiquette/decorators.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/etiquette/decorators.py b/etiquette/decorators.py index 7f8671e..a01fe5c 100644 --- a/etiquette/decorators.py +++ b/etiquette/decorators.py @@ -20,13 +20,11 @@ def required_fields(fields, forbid_whitespace=False): @functools.wraps(function) def wrapped(*args, **kwargs): for requirement in fields: - if ( - requirement not in request.form or - ( - forbid_whitespace and - request.form[requirement].strip() == '' - ) - ): + missing = ( + requirement not in request.form or + (forbid_whitespace and request.form[requirement].strip() == '') + ) + if missing: response = { 'error_type': 'MISSING_FIELDS', 'error_message': 'Required fields: %s' % ', '.join(fields),