From 9a234f42dcbc6ea160656ee886ebdd4634cd4176 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Bl=C3=A4sing?= <mblaesing@doppel-helix.eu>
Date: Mon, 24 Aug 2020 20:22:47 +0200
Subject: [PATCH] Fix XML structure for gpx export of recorded track

- gpx namespace is connected to schema location, but namespace is not
  attached to element ("xmlns" attribute is missing on "gpx" element)

- "name" element does not exist as a child of "gpx", but as a child of
  "metadata", which in turn is a child of "gpx"

- the order of the child elements of the "trkpt" element is reversed
---
 .../org/y20k/trackbook/helpers/TrackHelper.kt   | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/org/y20k/trackbook/helpers/TrackHelper.kt b/app/src/main/java/org/y20k/trackbook/helpers/TrackHelper.kt
index 99c5fc4..5a30b86 100644
--- a/app/src/main/java/org/y20k/trackbook/helpers/TrackHelper.kt
+++ b/app/src/main/java/org/y20k/trackbook/helpers/TrackHelper.kt
@@ -158,6 +158,7 @@ object TrackHelper {
         // add header
         gpxString = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\" ?>\n" +
                     "<gpx version=\"1.1\" creator=\"Trackbook App (Android)\"\n" +
+                    "     xmlns=\"http://www.topografix.com/GPX/1/1\"\n" +
                     "     xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n" +
                     "     xsi:schemaLocation=\"http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd\">\n"
 
@@ -180,9 +181,11 @@ object TrackHelper {
     /* Creates name for GPX file */
     private fun createGpxName(track: Track): String {
         val gpxName = StringBuilder("")
-        gpxName.append("\t<name>")
+        gpxName.append("\t<metadata>\n");
+        gpxName.append("\t\t<name>")
         gpxName.append("Trackbook Recording: ${track.name}")
         gpxName.append("</name>\n")
+        gpxName.append("\t</metadata>\n");
         return gpxName.toString()
     }
 
@@ -241,16 +244,16 @@ object TrackHelper {
             gpxTrack.append(wayPoint.longitude)
             gpxTrack.append("\">\n")
 
-            // add time
-            gpxTrack.append("\t\t\t\t<time>")
-            gpxTrack.append(dateFormat.format(Date(wayPoint.time)))
-            gpxTrack.append("</time>\n")
-
             // add altitude
             gpxTrack.append("\t\t\t\t<ele>")
             gpxTrack.append(wayPoint.altitude)
             gpxTrack.append("</ele>\n")
 
+            // add time
+            gpxTrack.append("\t\t\t\t<time>")
+            gpxTrack.append(dateFormat.format(Date(wayPoint.time)))
+            gpxTrack.append("</time>\n")
+
             // add closing tag
             gpxTrack.append("\t\t\t</trkpt>\n")
         }
@@ -279,4 +282,4 @@ object TrackHelper {
         return track
     }
 
-}
\ No newline at end of file
+}