voussoir/voussoirkit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix can_use_bare incorrectly handling nargs=* arguments.

Browse source
This commit is contained in:
Ethan Dalool 2020-08-20 11:39:04 -07:00
parent 3c8b76051f
commit a14902d124
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
voussoirkit/betterhelp.py
View file

@ -6,8 +6,17 @@ HELPSTRINGS = {'', 'help', '-h', '--help'}
# INTERNALS # INTERNALS
################################################################################ ################################################################################
def can_use_bare(parser): def can_use_bare(parser):
def is_required(action):
# I found that positional arguments marked with nargs=* were still being
# considered 'required', which is not what I want as far as can_use_bare
# goes. I believe option_strings==[] is what indicates this action is
# positional. If I'm wrong let's fix it.
if action.option_strings == [] and action.nargs == '*':
return False
return action.required
has_func = bool(parser.get_default('func')) has_func = bool(parser.get_default('func'))
has_required_args = any(action.required for action in parser._actions) has_required_args = any(is_required(action) for action in parser._actions)
return has_func and not has_required_args return has_func and not has_required_args
def can_use_bare_subparsers(subparser_action): def can_use_bare_subparsers(subparser_action):