voussoir/voussoirkit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make pool._job_manager_lock private to discourage outside editing.

Browse source
This commit is contained in:
Ethan Dalool 2020-02-12 19:11:55 -08:00
parent 7041448c82
commit bf5d621dd3
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
voussoirkit/threadpool.py
View file

@ -31,18 +31,18 @@ class ThreadPool:
self.closed = False self.closed = False
self.paused = paused self.paused = paused
self._jobs = [] self._jobs = []
self.job_manager_lock = threading.Lock() self._job_manager_lock = threading.Lock()
def _clear_done_jobs(self): def _clear_done_jobs(self):
''' '''
This function assumes that job_manager_lock is acquired!! This function assumes that _job_manager_lock is acquired!!
You should call clear_done_and_start_jobs instead! You should call clear_done_and_start_jobs instead!
''' '''
self._jobs[:] = [j for j in self._jobs if j.status in {PENDING, RUNNING}] self._jobs[:] = [j for j in self._jobs if j.status in {PENDING, RUNNING}]
def _start_jobs(self): def _start_jobs(self):
''' '''
This function assumes that job_manager_lock is acquired!! This function assumes that _job_manager_lock is acquired!!
You should call clear_done_and_start_jobs instead! You should call clear_done_and_start_jobs instead!
''' '''
available = self.max_size - self.running_count() available = self.max_size - self.running_count()
@ -60,7 +60,7 @@ class ThreadPool:
def _clear_done_and_start_jobs(self): def _clear_done_and_start_jobs(self):
''' '''
This function assumes that job_manager_lock is acquired!! This function assumes that _job_manager_lock is acquired!!
You should call clear_done_and_start_jobs instead! You should call clear_done_and_start_jobs instead!
''' '''
self._clear_done_jobs() self._clear_done_jobs()
@ -97,7 +97,7 @@ class ThreadPool:
a human friendly name string. a human friendly name string.
''' '''
self.assert_not_closed() self.assert_not_closed()
self.job_manager_lock.acquire() self._job_manager_lock.acquire()
job = Job( job = Job(
pool=self, pool=self,
@ -111,7 +111,7 @@ class ThreadPool:
if not self.paused: if not self.paused:
self._clear_done_and_start_jobs() self._clear_done_and_start_jobs()
self.job_manager_lock.release() self._job_manager_lock.release()
return job return job
def add_many(self, kwargss): def add_many(self, kwargss):
@ -127,7 +127,7 @@ class ThreadPool:
] ]
''' '''
self.assert_not_closed() self.assert_not_closed()
self.job_manager_lock.acquire() self._job_manager_lock.acquire()
these_jobs = [] these_jobs = []
for kwargs in kwargss: for kwargs in kwargss:
@ -139,7 +139,7 @@ class ThreadPool:
if not self.paused: if not self.paused:
self._clear_done_and_start_jobs() self._clear_done_and_start_jobs()
self.job_manager_lock.release() self._job_manager_lock.release()
return these_jobs return these_jobs
def clear_done_and_start_jobs(self): def clear_done_and_start_jobs(self):
@ -154,10 +154,10 @@ class ThreadPool:
Because the pool's internal job queue is flushed regularly, you should Because the pool's internal job queue is flushed regularly, you should
store your own references to jobs to get their return values. store your own references to jobs to get their return values.
''' '''
self.job_manager_lock.acquire() self._job_manager_lock.acquire()
self._clear_done_and_start_jobs() self._clear_done_and_start_jobs()
self.paused = False self.paused = False
self.job_manager_lock.release() self._job_manager_lock.release()
def join(self): def join(self):
''' '''