voussoir/voussoirkit
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make job._joinme_lock private to discourage outside editing.

Browse source
This commit is contained in:
Ethan Dalool 2020-02-12 19:12:12 -08:00
parent bf5d621dd3
commit f6872e77cf
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
voussoirkit/threadpool.py
View file

@ -187,12 +187,12 @@ class Job:
self.exception = NO_EXCEPTION self.exception = NO_EXCEPTION
self._thread = None self._thread = None
# joinme_lock works because it is possible for a single thread to block # _joinme_lock works because it is possible for a single thread to block
# itself by calling `lock.acquire()` twice. The first call is here, # itself by calling `lock.acquire()` twice. The first call is here,
# and the second call is in `join` so that join will block until the # and the second call is in `join` so that join will block until the
# lock is released by the job's finishing phase. # lock is released by the job's finishing phase.
self.joinme_lock = threading.Lock() self._joinme_lock = threading.Lock()
self.joinme_lock.acquire() self._joinme_lock.acquire()
def __repr__(self): def __repr__(self):
if self.name: if self.name:
@ -204,8 +204,8 @@ class Job:
''' '''
Block until this job runs and completes. Block until this job runs and completes.
''' '''
self.joinme_lock.acquire() self._joinme_lock.acquire()
self.joinme_lock.release() self._joinme_lock.release()
def start(self): def start(self):
''' '''
@ -223,7 +223,7 @@ class Job:
self.status = RAISED self.status = RAISED
self._thread = None self._thread = None
self.pool._job_finished() self.pool._job_finished()
self.joinme_lock.release() self._joinme_lock.release()
self.status = RUNNING self.status = RUNNING
self._thread = threading.Thread(target=do_it) self._thread = threading.Thread(target=do_it)