voussoir/ycdl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use .get instead of [] to handle missing some attributes.

Browse source 
Some of these are ones I've experienced first-hand, others are
defensive because I realized I don't know what kind of weird
things might be out there. Can do more if necessary.
This commit is contained in:
voussoir 2020-06-17 08:40:18 -07:00
parent ff1b043279
commit b3d3e4ae6c
1 changed files with 17 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
ycdl/ytapi.py
View file

@ -12,6 +12,11 @@ logging.getLogger('requests.packages.urllib3.connectionpool').setLevel(logging.W
logging.getLogger('requests.packages.urllib3.util.retry').setLevel(logging.WARNING) logging.getLogger('requests.packages.urllib3.util.retry').setLevel(logging.WARNING)
def int_none(x):
if x is None:
return None
return int(x)
class VideoNotFound(Exception): class VideoNotFound(Exception):
pass pass
@ -23,23 +28,23 @@ class Video:
content_details = data['contentDetails'] content_details = data['contentDetails']
statistics = data['statistics'] statistics = data['statistics']
self.title = snippet['title'] or '[untitled]' self.title = snippet.get('title', '[untitled]')
self.description = snippet['description'] self.description = snippet.get('description', '')
self.author_id = snippet['channelId'] self.author_id = snippet['channelId']
self.author_name = snippet['channelTitle'] self.author_name = snippet.get('channelTitle', self.author_id)
# Something like '2016-10-01T21:00:01' # Something like '2016-10-01T21:00:01'
self.published_string = snippet['publishedAt'] self.published_string = snippet['publishedAt']
published = snippet['publishedAt'].split('.')[0] published = snippet['publishedAt'].split('.')[0]
published = published.rstrip('Z') published = published.rstrip('Z')
published = datetime.datetime.strptime(published, '%Y-%m-%dT%H:%M:%S') published = datetime.datetime.strptime(published, '%Y-%m-%dT%H:%M:%S')
self.published = published.timestamp() self.published = published.timestamp()
self.tags = snippet['tags'] self.tags = snippet.get('tags', [])
self.duration = isodate.parse_duration(content_details['duration']).seconds self.duration = isodate.parse_duration(content_details['duration']).seconds
self.views = int(statistics['viewCount']) self.views = int_none(statistics.get('viewCount', None))
self.likes = int(statistics['likeCount']) self.likes = int_none(statistics.get('likeCount', 0))
self.dislikes = int(statistics['dislikeCount']) self.dislikes = int_none(statistics.get('dislikeCount'))
self.comment_count = int(statistics['commentCount']) self.comment_count = int_none(statistics.get('commentCount'))
thumbnails = snippet['thumbnails'] thumbnails = snippet['thumbnails']
best_thumbnail = max(thumbnails, key=lambda x: thumbnails[x]['width'] * thumbnails[x]['height']) best_thumbnail = max(thumbnails, key=lambda x: thumbnails[x]['width'] * thumbnails[x]['height'])
@ -136,10 +141,12 @@ class Youtube:
for snippet in snippets: for snippet in snippets:
try: try:
videos.append(Video(snippet)) videos.append(Video(snippet))
except KeyError: except KeyError as exc:
print(f'KEYERROR: {exc} not in {snippet}')
broken.append(snippet) broken.append(snippet)
if broken: if broken:
print('broken:', broken) # print('broken:', broken)
pass
if singular: if singular:
if len(videos) == 1: if len(videos) == 1:
return videos[0] return videos[0]