Add return to these onchange and ondrag attributes.
I skipped them during the commit where I added return to all onclicks because I figure I won't be wrapping these kinds of attributes. But I feel like it's better to be consistent and you never know when it might happen.
This commit is contained in:
		
							parent
							
								
									ad26f09ee0
								
							
						
					
					
						commit
						08f6c21286
					
				
					 2 changed files with 5 additions and 5 deletions
				
			
		|  | @ -6,10 +6,10 @@ | ||||||
| id="{{id}}" | id="{{id}}" | ||||||
| class="album_card album_card_{{view}}" | class="album_card album_card_{{view}}" | ||||||
| data-id="{{album.id}}" | data-id="{{album.id}}" | ||||||
| ondragstart="on_album_drag_start(event);" | ondragstart="return on_album_drag_start(event);" | ||||||
| ondragend="on_album_drag_end(event);" | ondragend="return on_album_drag_end(event);" | ||||||
| ondragover="on_album_drag_over(event);" | ondragover="return on_album_drag_over(event);" | ||||||
| ondrop="on_album_drag_drop(event);" | ondrop="return on_album_drag_drop(event);" | ||||||
| {% if album != "root" and draggable %} | {% if album != "root" and draggable %} | ||||||
| draggable=true | draggable=true | ||||||
| {% endif %} | {% endif %} | ||||||
|  |  | ||||||
|  | @ -154,7 +154,7 @@ | ||||||
| 
 | 
 | ||||||
| {% macro create_orderby_li(selected_column, selected_sorter) %} | {% macro create_orderby_li(selected_column, selected_sorter) %} | ||||||
| <li class="search_builder_orderby_li"> | <li class="search_builder_orderby_li"> | ||||||
|     <select onchange="orderby_hide_direction_hook(event);"> |     <select onchange="return orderby_hide_direction_hook(event);"> | ||||||
|         <option value="created"   {{"selected" if selected_column=="created" else ""}}   >Creation date</option> |         <option value="created"   {{"selected" if selected_column=="created" else ""}}   >Creation date</option> | ||||||
|         <option value="area"      {{"selected" if selected_column=="area" else ""}}      >Area</option> |         <option value="area"      {{"selected" if selected_column=="area" else ""}}      >Area</option> | ||||||
|         <option value="width"     {{"selected" if selected_column=="width" else ""}}     >Width</option> |         <option value="width"     {{"selected" if selected_column=="width" else ""}}     >Width</option> | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue