voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix incorrect short-circuit order of add_chidren bail.

Browse source
This commit is contained in:
voussoir 2020-09-27 19:49:27 -07:00
parent 06340d03da
commit 0eb8fd3f1b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
etiquette/objects.py
View file

@ -130,7 +130,7 @@ class GroupableMixin(metaclass=abc.ABCMeta):
def add_children(self, members): def add_children(self, members):
bail = True bail = True
for member in members: for member in members:
bail = bail and (self.__add_child(member) is BAIL) bail = (self.__add_child(member) is BAIL) and bail
if bail: if bail:
return BAIL return BAIL