voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove the + and x buttons on tags page.

Browse source 
I don't think they provide a whole lot of benefit since clicking
through to the tag itself and then searching is easy enough, and
these elements triple the number of dom nodes on the page.
This commit is contained in:
voussoir 2022-07-19 20:06:10 -07:00
parent 2562084fce
commit 145d0a8429
No known key found for this signature in database
GPG key ID: 5F7554F8C26DACCB
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frontends/etiquette_flask/templates/tags.html
View file

@ -155,8 +155,8 @@
<ul id="tag_list"> <ul id="tag_list">
{% for (qualified_name, tag) in tags %} {% for (qualified_name, tag) in tags %}
<li> <li>
{{cards.create_tag_card(tag, link="search_musts", extra_classes="must_shortcut", innertext="(+)")}} {# cards.create_tag_card(tag, link="search_musts", extra_classes="must_shortcut", innertext="(+)") #}
{{cards.create_tag_card(tag, link="search_forbids", extra_classes="forbid_shortcut", innertext="(x)")}} {# cards.create_tag_card(tag, link="search_forbids", extra_classes="forbid_shortcut", innertext="(x)") #}
{{cards.create_tag_card(tag, link="info", extra_classes="main_card", innertext=qualified_name, with_alt_description=True)-}} {{cards.create_tag_card(tag, link="info", extra_classes="main_card", innertext=qualified_name, with_alt_description=True)-}}
{% if specific_tag or '.' in qualified_name -%} {% if specific_tag or '.' in qualified_name -%}
<button <button
@ -188,8 +188,8 @@
{% if include_synonyms %} {% if include_synonyms %}
{% for synonym in tag.get_synonyms()|sort %} {% for synonym in tag.get_synonyms()|sort %}
<li> <li>
{{-cards.create_tag_card(tag, link="search_musts", extra_classes="must_shortcut", innertext="(+)")}} {# -cards.create_tag_card(tag, link="search_musts", extra_classes="must_shortcut", innertext="(+)") #}
{{cards.create_tag_card(tag, link="search_forbids", extra_classes="forbid_shortcut", innertext="(x)")}} {# cards.create_tag_card(tag, link="search_forbids", extra_classes="forbid_shortcut", innertext="(x)") #}
{{cards.create_tag_card(tag, link='info', extra_classes="main_card", innertext=qualified_name + '+' + synonym)-}} {{cards.create_tag_card(tag, link='info', extra_classes="main_card", innertext=qualified_name + '+' + synonym)-}}
<button <button
class="remove_tag_button red_button button_with_confirm" class="remove_tag_button red_button button_with_confirm"