voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove return value from load_config, so no illusion of purity.

Browse source 
This method already relies on object state anyway and writes back
to self.config, so the return value is unnecessary.
This commit is contained in:
voussoir 2018-08-11 18:19:10 -07:00
parent 9eb9220ca9
commit 3b3c690ae3
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
etiquette/photodb.py
View file

@ -1313,7 +1313,7 @@ class PhotoDB(
# CONFIG # CONFIG
self.config_filepath = self.data_directory.with_child(constants.DEFAULT_CONFIGNAME) self.config_filepath = self.data_directory.with_child(constants.DEFAULT_CONFIGNAME)
self.config = self.load_config() self.load_config()
self.log.setLevel(self.config['log_level']) self.log.setLevel(self.config['log_level'])
# OTHER # OTHER
@ -1542,8 +1542,6 @@ class PhotoDB(
if needs_dump: if needs_dump:
self.save_config() self.save_config()
return config
def save_config(self): def save_config(self):
with open(self.config_filepath.absolute_path, 'w', encoding='utf-8') as handle: with open(self.config_filepath.absolute_path, 'w', encoding='utf-8') as handle:
handle.write(json.dumps(self.config, indent=4, sort_keys=True)) handle.write(json.dumps(self.config, indent=4, sort_keys=True))