voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix entry_with_replacements unable to select text.

Browse source 
This hook had a bug where you couldn't select text because every
time you push a button, including ctrl+a or shift+left/right, the
cursor position gets reset and then deselects immediately.

So let's only reset the content and cursor only when text changes,
so arrow keys and ctrl don't have any negative effects.
This commit is contained in:
voussoir 2020-01-30 12:28:28 -08:00
parent eff0efdf40
commit 4da331a3ab
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontends/etiquette_flask/static/js/common.js
View file

@ -129,9 +129,13 @@ common.entry_with_tagname_replacements =
function entry_with_tagname_replacements(event)
{
var cursor_position = event.target.selectionStart;
event.target.value = common.tagname_replacements(event.target.value);
event.target.selectionStart = cursor_position;
event.target.selectionEnd = cursor_position;
var new_value = common.tagname_replacements(event.target.value);
if (new_value != event.target.value)
{
event.target.value = new_value;
event.target.selectionStart = cursor_position;
event.target.selectionEnd = cursor_position;
}
}
common.html_to_element =