voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve bookmark appearance; don't send edit with blank url.

Browse source
This commit is contained in:
voussoir 2018-02-17 19:36:48 -08:00
parent 91d445a877
commit 6ad41eb516
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frontends/etiquette_flask/templates/bookmarks.html
View file

@ -25,6 +25,8 @@
padding: 8px; padding: 8px;
margin: 8px; margin: 8px;
width: 500px;
max-width: 500px;
border-radius: 8px; border-radius: 8px;
box-shadow: 2px 2px 5px 0px rgba(0,0,0,0.25); box-shadow: 2px 2px 5px 0px rgba(0,0,0,0.25);
@ -48,7 +50,7 @@
<a href="{{bookmark.url}}" <a href="{{bookmark.url}}"
class="bookmark_title" class="bookmark_title"
data-editor-id="title" data-editor-id="title"
data-editor-placeholder="title" data-editor-placeholder="title (optional)"
data-editor-empty-text="{{bookmark.id}}"> data-editor-empty-text="{{bookmark.id}}">
{%- if bookmark.title -%} {%- if bookmark.title -%}
{{bookmark.title}} {{bookmark.title}}
@ -66,7 +68,7 @@
</div> </div>
{% endfor %} {% endfor %}
<div class="new_bookmark_card"> <div class="new_bookmark_card">
<input id="new_bookmark_title" type="text" placeholder="title"> <input id="new_bookmark_title" type="text" placeholder="title (optional)">
<input id="new_bookmark_url" type="text" placeholder="url"> <input id="new_bookmark_url" type="text" placeholder="url">
<button id="new_bookmark_button" class="green_button" onclick="submit_bookmark_form()">Create</button> <button id="new_bookmark_button" class="green_button" onclick="submit_bookmark_form()">Create</button>
</div> </div>
@ -111,6 +113,11 @@ function on_save(editor, edit_element_map)
{ {
var title_editor = edit_element_map["title"]; var title_editor = edit_element_map["title"];
var url_editor = edit_element_map["url"]; var url_editor = edit_element_map["url"];
url_editor.value = url_editor.value.trim();
if (!url_editor.value)
{
return;
}
editor.show_spinner(); editor.show_spinner();
function callback() function callback()