voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve this comment about Photo rename logic.

Browse source
This commit is contained in:
voussoir 2020-02-19 23:22:08 -08:00
parent f99d3d03d9
commit 8c854f3b6a
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
etiquette/objects.py
View file

@ -1013,11 +1013,14 @@ class Photo(ObjectBase):
os.makedirs(new_path.parent.absolute_path, exist_ok=True) os.makedirs(new_path.parent.absolute_path, exist_ok=True)
# The plan is to make a hardlink now, then delete the original file
# during commit. This only applies to normcase != normcase, because on
# case-insensitive systems (Windows), if we're trying to rename "AFILE"
# to "afile", we will not be able to hardlink nor copy the file to the
# new name, we'll just want to do an os.rename during commit.
if new_path.normcase != old_path.normcase: if new_path.normcase != old_path.normcase:
# It's possible on case-insensitive systems to have the paths point # If we're on the same partition, make a hardlink.
# to the same place while being differently cased, thus we couldn't # Otherwise make a copy.
# make the intermediate link.
# Instead, we will do a simple rename in just a moment.
try: try:
os.link(old_path.absolute_path, new_path.absolute_path) os.link(old_path.absolute_path, new_path.absolute_path)
except OSError: except OSError: