voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add message parameter to PDB.savepoint for better logging.

Browse source 
Helps to have a visual on which methods are creating the saves.
This commit is contained in:
voussoir 2018-07-29 16:03:04 -07:00
parent 56e7472c93
commit 9328600355
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
etiquette/decorators.py
View file

@ -78,7 +78,7 @@ def transaction(method):
@functools.wraps(method) @functools.wraps(method)
def wrapped_transaction(self, *args, **kwargs): def wrapped_transaction(self, *args, **kwargs):
photodb = _get_relevant_photodb(self) photodb = _get_relevant_photodb(self)
savepoint_id = photodb.savepoint() savepoint_id = photodb.savepoint(message=method.__qualname__)
try: try:
result = method(self, *args, **kwargs) result = method(self, *args, **kwargs)
except Exception as e: except Exception as e:

7
etiquette/photodb.py
View file

@ -720,9 +720,12 @@ class PDBSQLMixin:
if item == restore_to: if item == restore_to:
break break
def savepoint(self): def savepoint(self, message=None):
savepoint_id = helpers.random_hex(length=16) savepoint_id = helpers.random_hex(length=16)
self.log.debug('Savepoint %s.', savepoint_id) if message:
self.log.debug('Savepoint %s for %s.', savepoint_id, message)
else:
self.log.debug('Savepoint %s.', savepoint_id)
query = 'SAVEPOINT "%s"' % savepoint_id query = 'SAVEPOINT "%s"' % savepoint_id
self.sql.execute(query) self.sql.execute(query)
self.savepoints.append(savepoint_id) self.savepoints.append(savepoint_id)