voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Bail out of join_group early if already immediate parent.

Browse source 
I'd rather make the extra select than a delete and reinsert.
This commit is contained in:
voussoir 2018-05-03 18:18:13 -07:00
parent 22269af2ca
commit a0e3e037c1
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
etiquette/objects.py
View file

@ -198,6 +198,9 @@ class GroupableMixin:
if self == group: if self == group:
raise ValueError('Cant join self') raise ValueError('Cant join self')
if self.get_parent() == group:
return
self.leave_group(commit=False) self.leave_group(commit=False)
group.add_child(self, commit=commit) group.add_child(self, commit=commit)