voussoir/etiquette
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rename instances of Editor variables to clarify what they are.

Browse source
This commit is contained in:
voussoir 2020-10-17 17:26:07 -07:00
parent 45acdce74b
commit c146e0d1b9
2 changed files with 18 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
frontends/etiquette_flask/templates/album.html
View file

@ -321,13 +321,13 @@ function unpaste_photo_clipboard()
api.albums.remove_photos(ALBUM_ID, photo_ids, common.refresh); api.albums.remove_photos(ALBUM_ID, photo_ids, common.refresh);
} }
function on_open(ed, edit_element_map, display_element_map) function rename_ed_on_open(ed, edit_element_map, display_element_map)
{ {
ed.open(); ed.open();
edit_element_map["title"].focus(); edit_element_map["title"].focus();
} }
function on_save(ed, edit_element_map, display_element_map) function rename_ed_on_save(ed, edit_element_map, display_element_map)
{ {
function callback(response) function callback(response)
{ {
@ -358,7 +358,7 @@ function on_save(ed, edit_element_map, display_element_map)
api.albums.edit(ALBUM_ID, title, description, callback); api.albums.edit(ALBUM_ID, title, description, callback);
} }
function on_cancel(ed, edit_element_map, display_element_map) function rename_ed_on_cancel(ed, edit_element_map, display_element_map)
{ {
ed.cancel(); ed.cancel();
if (display_element_map["description"].innerText == "") if (display_element_map["description"].innerText == "")
@ -367,9 +367,12 @@ function on_cancel(ed, edit_element_map, display_element_map)
} }
} }
const title_text = document.getElementById("title_text"); const rename_ed = new editor.Editor(
const description_text = document.getElementById("description_text"); [document.getElementById("title_text"), document.getElementById("description_text")],
const ed = new editor.Editor([title_text, description_text], on_open, on_save, on_cancel); rename_ed_on_open,
rename_ed_on_save,
rename_ed_on_cancel
);
function add_album_datalist_on_load(datalist) function add_album_datalist_on_load(datalist)
{ {

15
frontends/etiquette_flask/templates/tags.html
View file

@ -375,13 +375,13 @@ function tag_action_callback(response)
} }
{% if specific_tag is not none %} {% if specific_tag is not none %}
function on_open(ed, edit_element_map) function rename_ed_on_open(ed, edit_element_map)
{ {
ed.open(); ed.open();
edit_element_map["name"].focus(); edit_element_map["name"].focus();
} }
function on_save(ed, edit_element_map, display_element_map) function rename_ed_on_save(ed, edit_element_map, display_element_map)
{ {
function callback(response) function callback(response)
{ {
@ -418,7 +418,7 @@ function on_save(ed, edit_element_map, display_element_map)
api.tags.edit(tag_name, new_name, new_description, callback) api.tags.edit(tag_name, new_name, new_description, callback)
} }
function on_cancel(ed, edit_element_map, display_element_map) function rename_ed_on_cancel(ed, edit_element_map, display_element_map)
{ {
ed.cancel(); ed.cancel();
if (display_element_map["description"].innerText == "") if (display_element_map["description"].innerText == "")
@ -427,9 +427,12 @@ function on_cancel(ed, edit_element_map, display_element_map)
} }
} }
const name_text = document.getElementById("name_text"); const rename_ed = new editor.Editor(
const description_text = document.getElementById("description_text"); [document.getElementById("name_text"), document.getElementById("description_text")],
const ed = new editor.Editor([name_text, description_text], on_open, on_save, on_cancel); rename_ed_on_open,
rename_ed_on_save,
rename_ed_on_cancel,
);
{% endif %} {% endif %}
</script> </script>
</html> </html>