voussoir
/
etiquette
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix add_children all(bail) causing short-circuit.

master
voussoir 2020-09-12 13:14:40 -07:00
parent bbadd15129
commit 5dcccae646
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
etiquette/objects.py
View File

@ -119,7 +119,10 @@ class GroupableMixin:
return self._add_child(member) return self._add_child(member)
def add_children(self, members): def add_children(self, members):
if all(self._add_child(member) is BAIL for member in members): bail = True
for member in members:
bail = bail and (self._add_child(member) is BAIL)
if bail:
return BAIL return BAIL
def assert_same_type(self, other): def assert_same_type(self, other):