Identify a logic error without actually fixing it.
😎
			
			
This commit is contained in:
		
							parent
							
								
									cc6e7a8b16
								
							
						
					
					
						commit
						bdff14ecf2
					
				
					 1 changed files with 5 additions and 0 deletions
				
			
		|  | @ -835,6 +835,11 @@ class PDBTagMixin: | ||||||
|             tagname = tagname.tagname |             tagname = tagname.tagname | ||||||
| 
 | 
 | ||||||
|         try: |         try: | ||||||
|  |             # TODO: this logic is flawed because tags that were created in | ||||||
|  |             # the past may have had different normalization. | ||||||
|  |             # At the same time, I don't want to just pass the input directly | ||||||
|  |             # into the query, we should still do SOME assumed normalization | ||||||
|  |             # like whitespace strip. | ||||||
|             tagname = objects.Tag.normalize_name( |             tagname = objects.Tag.normalize_name( | ||||||
|                 tagname, |                 tagname, | ||||||
|                 valid_chars=self.config['tag']['valid_chars'], |                 valid_chars=self.config['tag']['valid_chars'], | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue