Identify a logic error without actually fixing it.

😎
2019-04-26 23:14:14 -07:00 · 2019-04-26 23:14:14 -07:00 · bdff14ecf2
commit bdff14ecf2
parent cc6e7a8b16
1 changed files with 5 additions and 0 deletions
--- a/etiquette/photodb.py
+++ b/etiquette/photodb.py
@ -835,6 +835,11 @@ class PDBTagMixin:
            tagname = tagname.tagname

        try:
+            # TODO: this logic is flawed because tags that were created in
+            # the past may have had different normalization.
+            # At the same time, I don't want to just pass the input directly
+            # into the query, we should still do SOME assumed normalization
+            # like whitespace strip.
            tagname = objects.Tag.normalize_name(
                tagname,
                valid_chars=self.config['tag']['valid_chars'],