Commit graph

1381 commits

Author SHA1 Message Date
947d05a4fa Revert 488d793, reinstate PhotoDB.normalize_tagname.
In that commit, I missed three more calls in objects.py and
now I'm deciding that 5x copy-paste is not worth it.
2019-06-15 16:49:52 -07:00
8063f338f8 Add Refresh Directories button to album toolbox. 2019-06-15 16:04:33 -07:00
802c12937b Replace bespoke spinner with new button_with_spinner. 2019-06-15 16:04:06 -07:00
f842c2e49b Add button_with_spinner class. 2019-06-15 16:02:41 -07:00
83b7143753 Fix 'this' in the delayed spinner timeout. 2019-06-15 14:30:23 -07:00
311d1bbf8b Rearrange condition to be positive-first. 2019-06-15 14:24:50 -07:00
66c79f7d55 Use separate array of buttons to prevent index skipping.
I didn't know that the HTMLCollection would dynamically update,
and removing the class from the button would take them out
of the collection.
2019-06-15 13:49:33 -07:00
26bcafcbb5 Add style for button:disabled instead of switching classes. 2019-06-15 13:26:39 -07:00
a0164205a2 Remove button_with_confirm class from buttons once in progress. 2019-06-15 13:16:38 -07:00
4ab352a74d Fix bad check of ElementsByTagName. 2019-06-15 13:04:33 -07:00
9ab0a61cb3 Add endpoint for refreshing Album directories. 2019-06-15 02:44:46 -07:00
36a2ed9f88 Remove unnecessary _form functions that can be direct calls. 2019-06-15 02:42:33 -07:00
139d54f344 Improve the docstring for init_button_with_confirm. 2019-06-15 02:15:31 -07:00
65605253bf Add spacers between these sections of code. 2019-04-27 16:55:47 -07:00
4ddf578d63 Add spinner text to clipboard refresh metadata button.
Also replace usage of own in_progress variable with simply
disabling the button.
2019-04-27 16:55:26 -07:00
c7e4bf16d2 Pull spinner code into own file spinner.js.
For the purposes of editor.js this does not bring much improvement,
but now I can easily make spinners for other things.
2019-04-27 15:42:02 -07:00
09e80f5dba Replace bespoke add_, create_child buttons with confirm buttons. 2019-04-27 15:33:28 -07:00
ab4f240a30 Add input option to button_with_confirm to make mini submit forms. 2019-04-27 15:30:33 -07:00
e0544adc06 Use Function instead of setAttribute to create onclick. 2019-04-27 15:28:22 -07:00
bdff14ecf2 Identify a logic error without actually fixing it.
😎
2019-04-26 23:14:14 -07:00
cc6e7a8b16 Improve line consistency across the PhotoDB.new_* methods.
By clarifying why some lines are above / below the generate_id
call and putting similar code in similar order to each other.
2019-04-26 23:12:55 -07:00
a9865d8546 Replace PhotoDB.normalize_tagname with real call to Tag.norm_name.
I originally did this because I didn't want to accidentally call
Tag.normalize_name and forget to pass the valid parameters. However,
having this single method be on PhotoDB while the other norms are
part of their proper class has been an eyesore.
So since there are only a few calls to this I'm just inlining them
and trusting to not forget if I add more in the future.
2019-04-26 23:06:41 -07:00
8c74e42a74 Add Album.has_any_associated_directory. 2019-04-26 18:55:03 -07:00
ebde5c7ee8 Give each object class a table and centralize db_row normer. 2019-04-26 18:52:56 -07:00
fa97dd5d3c Remove Tag._cached_synonyms. Not worthwhile. 2019-04-05 23:26:11 -07:00
d24f93809b Add message parameter to commit instead of logging separately.
The upside is that we can get rid of some redundancy and reduce
the friction of adding more commit messages.
The downside of this is that the log statement always reports from
commit, instead of the function calling commit. But with unique
messages this shouldn't be too much trouble and should be worth it.
2019-04-01 23:29:01 -07:00
68a567d266 Perform is None check before detailed type checks. 2019-04-01 23:17:35 -07:00
3aa064cde3 Move log statement to top of method. 2019-04-01 23:17:01 -07:00
2f33023025 Replace singular guard continue with simple if. 2019-04-01 23:16:25 -07:00
2f6f4675ee Give #left a right margin instead of 95% width & centering. 2019-03-22 18:36:44 -07:00
a9e9d9b32c Add a "Running" header, like the "Setting up" header. 2019-03-22 18:29:50 -07:00
ad140e485e Two small docstring improvements. 2019-03-16 13:09:02 -07:00
572349c1f1 Show the child / photo count on the tooltip as well. 2019-03-16 13:07:29 -07:00
1b5770b81a Somewhat improve appearance of album cards on narrow screens.
Previously, on very narrow screens, the album cards were spilling
out of the container. Now they are better contained but I am
still not 100% satisfied with the margins between them.
2019-03-16 13:07:00 -07:00
a52be02880 Give sticky_side z-index 1, important for narrow mode.
Without this, the grid-view album cards were displaying above
the sticky toolbox because of their position:relative, which
I can't get rid of at the moment.
2019-03-16 12:26:18 -07:00
cc98def9fb Remove margin-bottom from last child of #left. 2019-03-16 12:24:50 -07:00
59901cb344 Give #left a right margin instead of 95% width & centering. 2019-03-16 12:24:19 -07:00
9b72b3dff0 Use CSS Grid on photo.html, resolve some Chrome/FF differences.
- In Firefox, the image under flex would be full-res height
  instead of staying screen height.
  In this new Grid-based layout the image is the correct size.
  Left toolbox still uses flex, no problems with it.
- Redid the classing of the photo_viewer and eliminated
  photo_img_holder so that all media types follow the same markup.
- Added a CSS variable for tracking narrow mode instead of relying
  on coincidental properties like flex settings.
2019-01-16 19:22:21 -08:00
b864397242 Have bookmark editor show errors on non 200 responses. 2019-01-13 15:05:03 -08:00
536531848e Oops, fix broken bookmark editing api.js. 2019-01-13 14:58:23 -08:00
0eb9addb1c Use a single constant for both areas of caching duration. 2019-01-13 14:47:13 -08:00
a0faec9639 Have album editor show errors on non 200 responses. 2019-01-13 14:44:21 -08:00
465891e53a Add an error message field to the Editor. 2019-01-13 14:35:54 -08:00
d66dc53215 Require voussoirkit 0.0.28 for sqlhelpers.listify.
Instead of defining that within etiquette.
2019-01-01 18:08:47 -08:00
c8f7239e19 Remove unnecessary margin-top from #left elements.
margin-bottom is enough to keep the space between elements,
margin-top was just adding an ugly distance from the header.
2019-01-01 17:21:44 -08:00
760ddfc6b0 Rename color_site_theme to color_theme_primary; and secondary. 2019-01-01 17:20:22 -08:00
5d7bc1ff4b Somewhat improve prettiness of hyphen range parse code. 2018-12-27 15:31:56 -08:00
6dcf47cab7 Remove duplicated markup between list/grid photo cards. 2018-12-27 15:30:30 -08:00
669247415f Add counts to the parent and child hierarchy headers. 2018-12-23 16:00:28 -08:00
29e999ccac Remove "children/photos" in favor of hover text.
To reduce visual clutter.
2018-12-23 15:59:50 -08:00