Commit graph

1313 commits

Author SHA1 Message Date
e0544adc06 Use Function instead of setAttribute to create onclick. 2019-04-27 15:28:22 -07:00
bdff14ecf2 Identify a logic error without actually fixing it.
😎
2019-04-26 23:14:14 -07:00
cc6e7a8b16 Improve line consistency across the PhotoDB.new_* methods.
By clarifying why some lines are above / below the generate_id
call and putting similar code in similar order to each other.
2019-04-26 23:12:55 -07:00
a9865d8546 Replace PhotoDB.normalize_tagname with real call to Tag.norm_name.
I originally did this because I didn't want to accidentally call
Tag.normalize_name and forget to pass the valid parameters. However,
having this single method be on PhotoDB while the other norms are
part of their proper class has been an eyesore.
So since there are only a few calls to this I'm just inlining them
and trusting to not forget if I add more in the future.
2019-04-26 23:06:41 -07:00
8c74e42a74 Add Album.has_any_associated_directory. 2019-04-26 18:55:03 -07:00
ebde5c7ee8 Give each object class a table and centralize db_row normer. 2019-04-26 18:52:56 -07:00
fa97dd5d3c Remove Tag._cached_synonyms. Not worthwhile. 2019-04-05 23:26:11 -07:00
d24f93809b Add message parameter to commit instead of logging separately.
The upside is that we can get rid of some redundancy and reduce
the friction of adding more commit messages.
The downside of this is that the log statement always reports from
commit, instead of the function calling commit. But with unique
messages this shouldn't be too much trouble and should be worth it.
2019-04-01 23:29:01 -07:00
68a567d266 Perform is None check before detailed type checks. 2019-04-01 23:17:35 -07:00
3aa064cde3 Move log statement to top of method. 2019-04-01 23:17:01 -07:00
2f33023025 Replace singular guard continue with simple if. 2019-04-01 23:16:25 -07:00
2f6f4675ee Give #left a right margin instead of 95% width & centering. 2019-03-22 18:36:44 -07:00
a9e9d9b32c Add a "Running" header, like the "Setting up" header. 2019-03-22 18:29:50 -07:00
ad140e485e Two small docstring improvements. 2019-03-16 13:09:02 -07:00
572349c1f1 Show the child / photo count on the tooltip as well. 2019-03-16 13:07:29 -07:00
1b5770b81a Somewhat improve appearance of album cards on narrow screens.
Previously, on very narrow screens, the album cards were spilling
out of the container. Now they are better contained but I am
still not 100% satisfied with the margins between them.
2019-03-16 13:07:00 -07:00
a52be02880 Give sticky_side z-index 1, important for narrow mode.
Without this, the grid-view album cards were displaying above
the sticky toolbox because of their position:relative, which
I can't get rid of at the moment.
2019-03-16 12:26:18 -07:00
cc98def9fb Remove margin-bottom from last child of #left. 2019-03-16 12:24:50 -07:00
59901cb344 Give #left a right margin instead of 95% width & centering. 2019-03-16 12:24:19 -07:00
9b72b3dff0 Use CSS Grid on photo.html, resolve some Chrome/FF differences.
- In Firefox, the image under flex would be full-res height
  instead of staying screen height.
  In this new Grid-based layout the image is the correct size.
  Left toolbox still uses flex, no problems with it.
- Redid the classing of the photo_viewer and eliminated
  photo_img_holder so that all media types follow the same markup.
- Added a CSS variable for tracking narrow mode instead of relying
  on coincidental properties like flex settings.
2019-01-16 19:22:21 -08:00
b864397242 Have bookmark editor show errors on non 200 responses. 2019-01-13 15:05:03 -08:00
536531848e Oops, fix broken bookmark editing api.js. 2019-01-13 14:58:23 -08:00
0eb9addb1c Use a single constant for both areas of caching duration. 2019-01-13 14:47:13 -08:00
a0faec9639 Have album editor show errors on non 200 responses. 2019-01-13 14:44:21 -08:00
465891e53a Add an error message field to the Editor. 2019-01-13 14:35:54 -08:00
d66dc53215 Require voussoirkit 0.0.28 for sqlhelpers.listify.
Instead of defining that within etiquette.
2019-01-01 18:08:47 -08:00
c8f7239e19 Remove unnecessary margin-top from #left elements.
margin-bottom is enough to keep the space between elements,
margin-top was just adding an ugly distance from the header.
2019-01-01 17:21:44 -08:00
760ddfc6b0 Rename color_site_theme to color_theme_primary; and secondary. 2019-01-01 17:20:22 -08:00
5d7bc1ff4b Somewhat improve prettiness of hyphen range parse code. 2018-12-27 15:31:56 -08:00
6dcf47cab7 Remove duplicated markup between list/grid photo cards. 2018-12-27 15:30:30 -08:00
669247415f Add counts to the parent and child hierarchy headers. 2018-12-23 16:00:28 -08:00
29e999ccac Remove "children/photos" in favor of hover text.
To reduce visual clutter.
2018-12-23 15:59:50 -08:00
746d094d81 Remove duplicated markup between list/grid album cards. 2018-12-23 15:51:38 -08:00
be976d584c Tiny markup cleanup for album card. 2018-12-23 15:36:40 -08:00
3d81b5508c Oops, add data-id to the list view album card. 2018-12-23 15:28:55 -08:00
c6c6158062 Save this assignment until it's needed. 2018-12-21 23:44:50 -08:00
d736c81100 Minor alignments within cards. 2018-12-21 23:44:11 -08:00
7674610b88 Somewhat simplify a few conditions in photodb init. 2018-11-24 22:25:25 -08:00
1eb5a6f465 Rename DatabaseOutOfDate's parameter 'current' -> 'existing'. 2018-11-24 22:06:16 -08:00
1f45be9c39 Provide #right first, since #left is often slower to load. 2018-11-17 17:52:40 -08:00
dfbdaa5e99 Let specific tag name be a link. 2018-11-17 17:44:17 -08:00
59fdda6c6b Use a similar hierarchy box style as the album page. 2018-11-17 17:37:34 -08:00
e562658d42 Remove unnecessary extra indent. 2018-11-17 17:36:47 -08:00
5dcb86eed5 Rearrange some css. 2018-11-17 16:57:07 -08:00
3788c844bf Let album title editor use same font size as title itself. 2018-11-17 16:55:47 -08:00
074594a8bc Fix #right button_with_confirm from width-jumping on load.
And any other similar element.
2018-11-17 16:53:35 -08:00
e6072db4a1 Remove album_card minwidth, photo_card maxwidth.
If needed, we can set the size of the containing div.
But having these hardcoded sizes was causing ugliness.
2018-11-17 16:51:54 -08:00
e25e0798c9 Add editor button placeholder to stop page jump on load. 2018-11-17 16:50:41 -08:00
707fdcc637 Add album cards and improve album pages.
- album card has placeholder for future thumbnail.
- replaced nested tree hierarchy lists with separate boxes.
- list/grid view also applies to the root listing.
- added a sticky right panel for all the tools. not pretty yet.
- mechanism for adding sticky panel changed. instead of applying
  it to the #right, you apply it to #content_body so that its
  grid layout can be updated properly.
2018-11-12 22:15:59 -08:00
d0208154e4 Add a function to clarify SQL_COLUMNS creation. 2018-11-11 19:08:31 -08:00