Commit Graph

869 Commits (45b42d3ca369f937023e26b4184f85162346a999)

Author SHA1 Message Date
voussoir 139d54f344 Improve the docstring for init_button_with_confirm. 2019-06-15 02:15:31 -07:00
voussoir 65605253bf Add spacers between these sections of code. 2019-04-27 16:55:47 -07:00
voussoir 4ddf578d63 Add spinner text to clipboard refresh metadata button.
Also replace usage of own in_progress variable with simply
disabling the button.
2019-04-27 16:55:26 -07:00
voussoir c7e4bf16d2 Pull spinner code into own file spinner.js.
For the purposes of editor.js this does not bring much improvement,
but now I can easily make spinners for other things.
2019-04-27 15:42:02 -07:00
voussoir 09e80f5dba Replace bespoke add_, create_child buttons with confirm buttons. 2019-04-27 15:33:28 -07:00
voussoir ab4f240a30 Add input option to button_with_confirm to make mini submit forms. 2019-04-27 15:30:33 -07:00
voussoir e0544adc06 Use Function instead of setAttribute to create onclick. 2019-04-27 15:28:22 -07:00
voussoir bdff14ecf2 Identify a logic error without actually fixing it.
😎
2019-04-26 23:14:14 -07:00
voussoir cc6e7a8b16 Improve line consistency across the PhotoDB.new_* methods.
By clarifying why some lines are above / below the generate_id
call and putting similar code in similar order to each other.
2019-04-26 23:12:55 -07:00
voussoir a9865d8546 Replace PhotoDB.normalize_tagname with real call to Tag.norm_name.
I originally did this because I didn't want to accidentally call
Tag.normalize_name and forget to pass the valid parameters. However,
having this single method be on PhotoDB while the other norms are
part of their proper class has been an eyesore.
So since there are only a few calls to this I'm just inlining them
and trusting to not forget if I add more in the future.
2019-04-26 23:06:41 -07:00
voussoir 8c74e42a74 Add Album.has_any_associated_directory. 2019-04-26 18:55:03 -07:00
voussoir ebde5c7ee8 Give each object class a `table` and centralize db_row normer. 2019-04-26 18:52:56 -07:00
voussoir fa97dd5d3c Remove Tag._cached_synonyms. Not worthwhile. 2019-04-05 23:26:11 -07:00
voussoir d24f93809b Add message parameter to commit instead of logging separately.
The upside is that we can get rid of some redundancy and reduce
the friction of adding more commit messages.
The downside of this is that the log statement always reports from
commit, instead of the function calling commit. But with unique
messages this shouldn't be too much trouble and should be worth it.
2019-04-01 23:29:01 -07:00
voussoir 68a567d266 Perform is None check before detailed type checks. 2019-04-01 23:17:35 -07:00
voussoir 3aa064cde3 Move log statement to top of method. 2019-04-01 23:17:01 -07:00
voussoir 2f33023025 Replace singular guard continue with simple if. 2019-04-01 23:16:25 -07:00
voussoir 2f6f4675ee Give #left a right margin instead of 95% width & centering. 2019-03-22 18:36:44 -07:00
voussoir a9e9d9b32c Add a "Running" header, like the "Setting up" header. 2019-03-22 18:29:50 -07:00
voussoir ad140e485e Two small docstring improvements. 2019-03-16 13:09:02 -07:00
voussoir 572349c1f1 Show the child / photo count on the tooltip as well. 2019-03-16 13:07:29 -07:00
voussoir 1b5770b81a Somewhat improve appearance of album cards on narrow screens.
Previously, on very narrow screens, the album cards were spilling
out of the container. Now they are better contained but I am
still not 100% satisfied with the margins between them.
2019-03-16 13:07:00 -07:00
voussoir a52be02880 Give sticky_side z-index 1, important for narrow mode.
Without this, the grid-view album cards were displaying above
the sticky toolbox because of their position:relative, which
I can't get rid of at the moment.
2019-03-16 12:26:18 -07:00
voussoir cc98def9fb Remove margin-bottom from last child of #left. 2019-03-16 12:24:50 -07:00
voussoir 59901cb344 Give #left a right margin instead of 95% width & centering. 2019-03-16 12:24:19 -07:00
voussoir 9b72b3dff0 Use CSS Grid on photo.html, resolve some Chrome/FF differences.
- In Firefox, the image under flex would be full-res height
  instead of staying screen height.
  In this new Grid-based layout the image is the correct size.
  Left toolbox still uses flex, no problems with it.
- Redid the classing of the photo_viewer and eliminated
  photo_img_holder so that all media types follow the same markup.
- Added a CSS variable for tracking narrow mode instead of relying
  on coincidental properties like flex settings.
2019-01-16 19:22:21 -08:00
voussoir b864397242 Have bookmark editor show errors on non 200 responses. 2019-01-13 15:05:03 -08:00
voussoir 536531848e Oops, fix broken bookmark editing api.js. 2019-01-13 14:58:23 -08:00
voussoir 0eb9addb1c Use a single constant for both areas of caching duration. 2019-01-13 14:47:13 -08:00
voussoir a0faec9639 Have album editor show errors on non 200 responses. 2019-01-13 14:44:21 -08:00
voussoir 465891e53a Add an error message field to the Editor. 2019-01-13 14:35:54 -08:00
voussoir d66dc53215 Require voussoirkit 0.0.28 for sqlhelpers.listify.
Instead of defining that within etiquette.
2019-01-01 18:08:47 -08:00
voussoir c8f7239e19 Remove unnecessary margin-top from #left elements.
margin-bottom is enough to keep the space between elements,
margin-top was just adding an ugly distance from the header.
2019-01-01 17:21:44 -08:00
voussoir 760ddfc6b0 Rename color_site_theme to color_theme_primary; and secondary. 2019-01-01 17:20:22 -08:00
voussoir 5d7bc1ff4b Somewhat improve prettiness of hyphen range parse code. 2018-12-27 15:31:56 -08:00
voussoir 6dcf47cab7 Remove duplicated markup between list/grid photo cards. 2018-12-27 15:30:30 -08:00
voussoir 669247415f Add counts to the parent and child hierarchy headers. 2018-12-23 16:00:28 -08:00
voussoir 29e999ccac Remove "children/photos" in favor of hover text.
To reduce visual clutter.
2018-12-23 15:59:50 -08:00
voussoir 746d094d81 Remove duplicated markup between list/grid album cards. 2018-12-23 15:51:38 -08:00
voussoir be976d584c Tiny markup cleanup for album card. 2018-12-23 15:36:40 -08:00
voussoir 3d81b5508c Oops, add data-id to the list view album card. 2018-12-23 15:28:55 -08:00
voussoir c6c6158062 Save this assignment until it's needed. 2018-12-21 23:44:50 -08:00
voussoir d736c81100 Minor alignments within cards. 2018-12-21 23:44:11 -08:00
voussoir 7674610b88 Somewhat simplify a few conditions in photodb init. 2018-11-24 22:25:25 -08:00
voussoir 1eb5a6f465 Rename DatabaseOutOfDate's parameter 'current' -> 'existing'. 2018-11-24 22:06:16 -08:00
voussoir 1f45be9c39 Provide #right first, since #left is often slower to load. 2018-11-17 17:52:40 -08:00
voussoir dfbdaa5e99 Let specific tag name be a link. 2018-11-17 17:44:17 -08:00
voussoir 59fdda6c6b Use a similar hierarchy box style as the album page. 2018-11-17 17:37:34 -08:00
voussoir e562658d42 Remove unnecessary extra indent. 2018-11-17 17:36:47 -08:00
voussoir 5dcb86eed5 Rearrange some css. 2018-11-17 16:57:07 -08:00