Commit graph

28 commits

Author SHA1 Message Date
317fa3b51d Call assert_not_deleted before every @transaction. 2020-09-20 12:46:52 -07:00
497abf26cd Move circular dependency to end of file. 2020-09-20 12:46:38 -07:00
7b7015125e Add period to all exception messages. 2020-09-19 03:32:16 -07:00
adb1d0ef39 Replace all double blank lines with single, improve hash headers.
There was always some semblance that two blank lines has some kind of
meaning or structure that's different from single blank lines, but
in reality it was mostly arbitrary and I can't stand to look at it
any more.
2020-09-19 03:13:23 -07:00
26b9371f26 When @transaction rolls back, log the name of the called method. 2020-09-17 18:33:56 -07:00
5b4cc5bf9c Log the exception before rolling back. 2020-09-14 20:25:24 -07:00
203fb9e00f @transaction intercept commit argument; commit / release here. 2020-02-19 22:36:00 -08:00
eff0efdf40 Indicate required feature in exception message. 2020-01-29 23:52:25 -08:00
9328600355 Add message parameter to PDB.savepoint for better logging.
Helps to have a visual on which methods are creating the saves.
2018-07-29 16:03:04 -07:00
4987db4bd0 Switch to f-string formatting in many places. 2018-07-18 18:36:36 -07:00
df7fbeae0a Minor clarity improvements to required_feature logic. 2018-04-27 20:04:18 -07:00
1cd78a678b Minor linter appeasements. 2018-03-11 01:54:59 -08:00
d88db08693 Allow PDB.rollback to take a savepoint; Warn early commits.
If a @transaction method makes calls to other @transaction
methods, and one of those nested calls makes a commit, and then
the outer call raises an exception, then the outer call will
not rollback properly because its savepoint is no longer in
the savepoint stack. So let's warn the user if that happens.
Should this raise an exception instead of just warn? Not sure,
I mean the data is already committed.
2018-03-05 21:35:36 -08:00
3d925c1426 Rename inner wrapped to improve traceback clarity.
Because "line 77, in wrapped_transaction" is at least slightly
better than "in wrapped".
2018-02-25 17:15:35 -08:00
c001b0fc87 Use SQL savepoints to improve @transaction.
I didn't know about these! Now we don't have to roll all the way
back in case of problems. This allows for raising exceptions as
control flow since they won't undo unrelated stuff.
2018-02-25 17:10:04 -08:00
13e8bc4a6f Add more items to to-do list; minor fixes. 2018-02-20 16:50:39 -08:00
bd847159fa Organize config by nesting related stuff.
I thought about switching to .ini files but that's even less desirable.
2017-07-29 16:23:15 -07:00
a7cb922983 Fix missing exceptions import 2017-06-14 22:47:50 -07:00
a9c7ad6993 Improve separation between front & back with etiquette_flask package
Move flask-specific operations out of etiquette's files and into new etiquette_flask. In etiquette_site.py, etiquette calls are fully qualified.
2017-05-01 21:23:16 -07:00
09f209719b Add decorators.@required_feature to centralize FeatureDisabled exc. 2017-05-01 20:41:56 -07:00
af6785cead Add decorators.@transaction to rollback sql upon exception 2017-05-01 20:23:58 -07:00
e62aa2f740 Make condition look better 2017-03-22 18:06:02 -07:00
5d1c2dfc40 Use URL to indicate POST action
Instead of passing 'action' as a field like a dummy.
2017-02-26 00:33:26 -08:00
c84acca6c9 Move modules into an actual package 2017-02-04 19:55:13 -08:00
2b34854910 Move files to top of repository 2016-11-28 20:19:31 -08:00
45a8a8ccc5 checkpoint 2016-11-27 01:06:11 -08:00
5de1736347 checkpoint 2016-11-05 21:24:43 -07:00
7ad6160d38 album .tar 2016-11-05 17:58:37 -07:00