Commit graph

12 commits

Author SHA1 Message Date
dd0ee7a72a Use more const. 2020-09-14 18:33:53 -07:00
139998172f Add spinner.BAIL for cancelling spinner without launching callback. 2020-09-04 11:25:11 -07:00
1f88b007cd Fine-tune use of let/const in spinner.js. 2020-09-03 15:57:02 -07:00
05b39c21fd Replace loop uses of var with let/const. 2020-09-03 15:33:37 -07:00
8af340e442 Replace non-global uses of var with let. 2020-09-03 15:31:47 -07:00
fe7b5de427 Replace many uses of forEach with for-of. 2020-09-03 14:18:05 -07:00
3e9e7e6a52 Add more to docstring about spinner delay attribute. 2020-07-10 16:34:20 -07:00
a56b5274c9 Read spinner button function from onclick instead of data-onclick.
I think my original reason for doing this was to prevent the button
from being operational until after the spinner initialization has
completed, so you don't get any weird half-functional spinner buttons.
However, in practice I'm finding that I constantly forget about this
and it adds tedium to creating spinner buttons.
Will review if any actual problems come up.
2020-06-17 14:04:27 -07:00
fdfc7308b0 Move all spinner related functions from common.js to spinner.js. 2020-06-17 12:41:13 -07:00
83b7143753 Fix 'this' in the delayed spinner timeout. 2019-06-15 14:30:23 -07:00
311d1bbf8b Rearrange condition to be positive-first. 2019-06-15 14:24:50 -07:00
c7e4bf16d2 Pull spinner code into own file spinner.js.
For the purposes of editor.js this does not bring much improvement,
but now I can easily make spinners for other things.
2019-04-27 15:42:02 -07:00