Commit graph

56 commits

Author SHA1 Message Date
4e3e2fea12 Avoid creating emptystring promptclass. 2020-10-03 18:32:21 -07:00
5d802ba9f9 Let response status be 0 even if request didn't complete.
Since meta.status would be undefined for an incomplete request,
I would have to check response.completed && response.meta.status,
which is too much burden. Let's set the status immediately, and
if a callback wants to do further diving we'll use completed then.
2020-10-02 19:43:36 -07:00
d15d5f9856 Set tabbed_container data-active-tab-id on tab change. 2020-10-02 16:53:00 -07:00
8da18ba502 Add --narrow, --wide to common.css, is_wide_mode to common.js. 2020-09-18 20:57:35 -07:00
1af8342202 Catch json parse errors, setting json_ok = false. 2020-09-15 23:10:35 -07:00
dd0ee7a72a Use more const. 2020-09-14 18:33:53 -07:00
8659b55103 Use className instead of classList here. 2020-09-14 12:01:33 -07:00
c532b711b1 During init_all, launch individuals as setTimeouts.
I'm having some performance issues with button_with_confirm on /tags.
This won't magically make that faster but I'm trying to stop the main
thread from dragging at least.
2020-09-14 05:54:47 -07:00
2dc1603d5e Use className instead of classList for initialization. 2020-09-14 05:19:10 -07:00
cc34c4d189 Pull out init_* function innards to separate one-item functions. 2020-09-12 20:34:59 -07:00
329c6dd27b Trim whitespace from html_to_element input. 2020-09-12 20:33:46 -07:00
be7decf330 Rearrange confirm_onclick because they have return statements now.
Now that data-onclick begins with a return statement, this code was
not running.
2020-09-12 14:33:15 -07:00
2fad1c58fd Use className instead of classList, as input may have spaces. 2020-09-12 13:14:55 -07:00
892390c77a Rewrite entry_with_history hook and use keydown instead of keyup. 2020-09-10 08:21:20 -07:00
348215a8ee Add whitelist/blacklist functionality to merge_params. 2020-09-04 15:10:41 -07:00
5356b19858 Add explanation of data-prompt-class et al.
I think I left these blank because I felt they should be obvious.
But I'd rather have it explicit.
2020-09-04 14:50:51 -07:00
7f48c3e97c Add css/js classes entry_with_history, _with_tagname_replacements. 2020-09-04 11:20:51 -07:00
05b39c21fd Replace loop uses of var with let/const. 2020-09-03 15:33:37 -07:00
8af340e442 Replace non-global uses of var with let. 2020-09-03 15:31:47 -07:00
fe7b5de427 Replace many uses of forEach with for-of. 2020-09-03 14:18:05 -07:00
45b42d3ca3 Add css/js class tabbed_container. 2020-09-03 11:54:14 -07:00
bff4a12fcb Add various comments, docstrings, and console.log. 2020-09-03 11:46:26 -07:00
2eed3ff1c5 Add css/js class enable_on_pageload. 2020-08-28 16:23:28 -07:00
7609f20dd0 Let button_with_confirm inherit original CSS when not specified. 2020-08-07 21:14:27 -07:00
0cb41f09cf Add docstring to bind_box_to_button, and some small linting. 2020-06-30 20:33:24 -07:00
68f52271f1 Dedent by using early returns. 2020-06-28 17:07:28 -07:00
b817a7e8b9 Use dot notation instead of subscript. 2020-06-28 16:55:48 -07:00
6cfa83e2d8 Add attribute "completed" to response object. 2020-06-28 16:52:08 -07:00
8c50700290 Add more docstring to button_with_confirm data-onclick parameter. 2020-06-17 14:08:03 -07:00
d6ca8206b4 Synchronize Etiquette common.js and YCDL common.js. 2020-06-17 13:38:20 -07:00
e1033d0138 Move tagname related functions from common.js to tag_autocomplete.js. 2020-06-17 12:42:08 -07:00
fdfc7308b0 Move all spinner related functions from common.js to spinner.js. 2020-06-17 12:41:13 -07:00
91ac2315e6 Put meta before data in the json responses. 2020-06-17 12:37:22 -07:00
136a47bf10 Add support for spinner groups, all buttons spin when one clicked. 2020-06-11 18:20:20 -07:00
2f5510fd0c Rename variable spinner_button_count -> spinner_button_index. 2020-05-28 19:01:42 -07:00
4da331a3ab Fix entry_with_replacements unable to select text.
This hook had a bug where you couldn't select text because every
time you push a button, including ctrl+a or shift+left/right, the
cursor position gets reset and then deselects immediately.

So let's only reset the content and cursor only when text changes,
so arrow keys and ctrl don't have any negative effects.
2020-01-30 12:28:28 -08:00
10b674e8d8 Add entry_with_tagname_replacements for use on tagname inputs.
Unfortunately, when adjusting the box's value, it causes the datalist
to disappear, and it only comes back after you press another key.
I can't figure out how to make the datalist reappear automatically
with js.
2020-01-15 20:29:56 -08:00
f842c2e49b Add button_with_spinner class. 2019-06-15 16:02:41 -07:00
66c79f7d55 Use separate array of buttons to prevent index skipping.
I didn't know that the HTMLCollection would dynamically update,
and removing the class from the button would take them out
of the collection.
2019-06-15 13:49:33 -07:00
a0164205a2 Remove button_with_confirm class from buttons once in progress. 2019-06-15 13:16:38 -07:00
4ab352a74d Fix bad check of ElementsByTagName. 2019-06-15 13:04:33 -07:00
139d54f344 Improve the docstring for init_button_with_confirm. 2019-06-15 02:15:31 -07:00
ab4f240a30 Add input option to button_with_confirm to make mini submit forms. 2019-04-27 15:30:33 -07:00
e0544adc06 Use Function instead of setAttribute to create onclick. 2019-04-27 15:28:22 -07:00
8a1d5d9eae Let the button_with_confirm give a class to its holder. 2018-09-23 15:03:50 -07:00
20e41ad689 Extremely minor touchups. 2018-09-23 14:57:25 -07:00
f28e362c58 Add space between ok, cancel buttons on editor & confirmer. 2018-08-16 19:46:33 -07:00
f047235c48 Reorganize a bunch of javascript handlers.
The javascript is very inconsistent between pages. I'm trying to
start using a consistent pattern where the api call is kept in a
separate function from the ones that buttons and input boxes
talk to.
2018-07-29 01:25:53 -07:00
fd6943fce1 Add code for creating buttions with confirmation prompts. 2018-07-28 20:21:20 -07:00
c7cce5a4e5 Add namespacing to common.js. 2018-07-22 20:21:00 -07:00